Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trust binaries signed for Waterfox (about:third-party) #3269

Merged

Conversation

goodusername123
Copy link
Contributor

@goodusername123 goodusername123 commented Nov 16, 2023

This should fix about:third-party not trusting any of Waterfox's DLL files.
This means the user can no longer "brick" their browser as shown in the images below, it also might improve performance to some extent since now the browser won't do any checking against core browser DLLs treating them like they are unknown.
Also this may help or solve issue #3187 although this is just a guess.

core browser DLL being treated as unknown/third-party:

Untitled31 webp

the result of blocking xul.dll and then attempting to launch Waterfox (the only way to get Waterfox working again is to go to %AppData%\WaterfoxLimited\Waterfox\ In Windows and delete everything in the "disabled" folder.):

Untitled32 webp

This fixes about:third-party not trusting any of Waterfox's dll files.
@MrAlex94 MrAlex94 merged commit 5233d51 into BrowserWorks:current Nov 17, 2023
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants